Fix: the CAMAC libraries now accept connection IDs of zero#3028
Merged
mwinkel-dev merged 2 commits intoMDSplus:alphafrom Feb 24, 2026
Merged
Fix: the CAMAC libraries now accept connection IDs of zero#3028mwinkel-dev merged 2 commits intoMDSplus:alphafrom
mwinkel-dev merged 2 commits intoMDSplus:alphafrom
Conversation
mwinkel-dev
requested review from
WhoBrokeTheBuild,
heidthecamp,
joshStillerman and
santorofer
mwinkel-dev
added
US Priority
tool/mdsip
Contributor
Author
|
Retest this please |
Member
|
Like all other things with this change, it will now work with modern MDSplus but will no longer work well with MDSplus before Timo's change, but this LGTM |
WhoBrokeTheBuild
approved these changes
Feb 24, 2026
Contributor
Author
|
PPPL confirmed that the two MDSplus servers involved with the CAMAC devices will both be running the forthcoming stable release. Thus, this CAMAC fix will work fine on those servers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes Issue #3024.
PR #2288 redefined
INVALID_CONNECTION_IDto be-1(it used to be zero). This fix changes two CAMAC libraries,libCamShr.soandlibRemCamShr.so, to accept zero as a valid connection ID. Developer builds of the libraries were tested by the user and confirmed to fix the problem. This fix needs to be included in a new "stable" release.